COMPAT: Update for NumPy dev #17987
COMPAT: Update for NumPy dev #17987
Conversation
TomAugspurger
added
the
Compat
| return np.fromstring(values, dtype=dtype) | ||
| # Copy the bytes into a numpy array. | ||
| buf = np.frombuffer(values, dtype=dtype) | ||
| buf = buf.copy() # required to not mutate the original data |
There was a problem hiding this comment.
I think it's safe to not copy here, IIRC values is pile of bytes read from a msgpack file, so no risk in mutating?
There was a problem hiding this comment.
Without the copy the test failed:
for buf, control_buf in zip(not_garbage, control):
# make sure none of our mutations above affected the
# original buffers
> assert buf == control_buf
E AssertionError: assert b'\x00\x00\x0...x00\x00@\x8f@' == bytearray(b'\x...00\x008\x8f@')
E At index 6 diff: 240 != 0
E Use -v to get the full diff
pandas/tests/io/test_packers.py:690: AssertionError
I didn't look closely to see if that's a legitimate problem or not.
There was a problem hiding this comment.
Ah, in that case I would trust the test.
There was a problem hiding this comment.
you need to do this conditionally for numpy > 1.13 I think
There was a problem hiding this comment.
The tests on the older NumPy passed, let me make sure zlib is installed and that they weren't skipped.
There was a problem hiding this comment.
Pretty sure that https://travis-ci.org/pandas-dev/pandas/jobs/292845756 hit it, so I think we're OK.
Codecov Report
@@ Coverage Diff @@
## master #17987 +/- ##
==========================================
+ Coverage 91.23% 91.57% +0.33%
==========================================
Files 163 163
Lines 50113 53390 +3277
==========================================
+ Hits 45723 48892 +3169
- Misses 4390 4498 +108
Continue to review full report at Codecov.
|
|
Huh, must have deleted that branch accidentally. |
|
thanks! |
Closes pandas-dev#17986 xref numpy/numpy#9487 (cherry picked from commit dff5109)
Closes #17986 xref numpy/numpy#9487 (cherry picked from commit dff5109)
Closes #17986
xref numpy/numpy#9487
Do we want this for 0.21?